Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/diffusive concentrations #2244

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Fix/diffusive concentrations #2244

wants to merge 3 commits into from

Conversation

boeschf
Copy link
Contributor

@boeschf boeschf commented Jan 9, 2024

attempts to fix #2209

@thorstenhater
Copy link
Contributor

Hey @boeschf,

thanks for tackling this. Quick question: did you build this on top of #2209 to see whether the tests are OK?

@boeschf
Copy link
Contributor Author

boeschf commented Jan 9, 2024

It's separate, but I'll test this on a separate branch with #2209 merged in. I'll report the results here. If preferred, I could push to #2209 directly, but I'd prefer a separate discussion here.

@thorstenhater
Copy link
Contributor

Whatever works better for you.

@boeschf boeschf mentioned this pull request Jan 10, 2024
Draft
@boeschf boeschf marked this pull request as draft January 11, 2024 10:58
@jlubo jlubo mentioned this pull request Feb 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boeschf @thorstenhater