Make (most) painted parameters scalable. #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdhocMan
reviewed
Jul 25, 2023
AdhocMan
requested changes
Aug 3, 2023
doc/concepts/decor.rst
Outdated
| @@ -194,6 +202,9 @@ Currently, only parameters of :ref:`density mechanisms <cablecell-density-mechs> | |||
| # paint a scaled density mechanism, where 'g' is scaled with the distance from the root. | |||
| decor.paint('"dend"', arbor.scaled_mechanism(arbor.density(m), {'g': '(distance 1.0 (root))'})) | |||
|
|
|||
| # initial value for the membrane potential | |||
| decor.paint('(all)', Vm=(42, '(diameter)')) | |||
There was a problem hiding this comment.
Is this still correct syntax with the recent changes?
There was a problem hiding this comment.
Nope, good catch!
doc/python/decor.rst
Outdated
| @@ -71,17 +71,19 @@ Cable cell decoration | |||
|
|
|||
| .. method:: paint(region, Vm=None, cm=None, rL=None, tempK=None) | |||
|
|
|||
| Set cable properties on a region. | |||
| Set cable properties on a region. If a pair of float ``v`` and a string | |||
There was a problem hiding this comment.
This should probably be changed to "float or string" as well. Same with the following lines.
AdhocMan
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow application of
iexprscaling onto