v0.8.1 #2072
Merged
v0.8.1 #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boeschf
reviewed
Dec 22, 2022
| @@ -1,4 +1,5 @@ | |||
| # pip requirements file | |||
| numpy!=1.24.0 # See https://github.com/numpy/numpy/issues/22826 | |||
There was a problem hiding this comment.
should we add this restriction also to the spack package?
There was a problem hiding this comment.
The restriction is only required for the examples (a single one in fact), which isn't a target in the spack package. So I don't think it's necessary.
There was a problem hiding this comment.
still, numpy is a dependency in the spack package when building with python, so would be nice to have imo
There was a problem hiding this comment.
This dependency is because Arbor exposes some data as numpy arrays (spike array). This won't trigger the bug. The user would need to write code themselves that runs into it.
Co-authored-by: boeschf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.