Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] a-b-c: actually set compiler, improved default #2051

Merged
merged 8 commits into from
Dec 6, 2022
Merged

[BUGFIX] a-b-c: actually set compiler, improved default #2051

merged 8 commits into from
Dec 6, 2022

Conversation

brenthuisman
Copy link
Contributor

@brenthuisman brenthuisman commented Nov 30, 2022 •
edited
Loading

  • Actually set the compiler to the user provided --cxx or the scripts default.
  • Have a fallback to c++ in case arbor.config()['CXX'] does not exist (typically true for pip installed wheels).
  • Verbose mode for a-b-c

@brenthuisman brenthuisman marked this pull request as ready for review December 1, 2022 14:59
@brenthuisman brenthuisman changed the title some sligthly improved defaults for a-b-c [BUGFIX] some sligthly improved defaults for a-b-c Dec 1, 2022
@brenthuisman brenthuisman changed the title [BUGFIX] some sligthly improved defaults for a-b-c [BUGFIX] a-b-c: actually set compiler, improved default Dec 1, 2022
boeschf
boeschf reviewed Dec 1, 2022
View reviewed changes
scripts/arbor-build-catalogue Outdated Show resolved Hide resolved
scripts/arbor-build-catalogue Outdated Show resolved Hide resolved
@brenthuisman brenthuisman merged commit 86b62b7 into arbor-sim:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boeschf boeschf boeschf approved these changes

@llandsmeer llandsmeer Awaiting requested review from llandsmeer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenthuisman @boeschf