-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make LIF cells LIF cells again. #2026
Conversation
thorstenhater
commented
Nov 2, 2022
•
edited
Loading
edited
- Add (again) a reset voltage E_R such that V_m = E_R in the refractory period.
- Make V_m decay towards resting potential E_L instead of 0.
- Adjust docs and tests accordingly.
- Double check this against literature.
- Add (again) a reset voltage E_R that for V_m = E_R in the refractory period. - Make V_m decay towards resting potential E_L instead of 0. - Adjust docs and tests accordingly. - Double check this against literature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny thing!
What would that be? :) There are no comments? |
doc/concepts/lif_cell.rst
Outdated
2. Otherwise :math:`U'_\mathrm{m}(t) = \sum\limits_\mathrm{spike} w_\mathrm{spike} \cdot\delta(t - t_\mathrm{spike}) -\frac{1}{\tau_\mathrm{m}}U_\mathrm{m}(t)` | ||
0. :math:`U_\mathrm{m}(0) = V_\mathrm{0}`, | ||
1. If the cell is in its refractory state :math:`U_\mathrm{m}(t) = E_\mathrm{R}` | ||
2. Otherwise :math:`U'_\mathrm{m}(t) = \sum\limits_\mathrm{spike} w_\mathrm{spike} \cdot\delta(t - t_\mathrm{spike}) - \frac{1}{\tau_\mathrm{m}}\left(U_\mathrm{m}(t)) - E_\mathrm{L}\right)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w_\mathrm{spike}
is not defined above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's not part of the cell, but it should still be defined somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There, it is now explained. I added C++ API docs for LIF as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hurray!