Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LIF cells LIF cells again. #2026

Merged
merged 6 commits into from
Nov 3, 2022

Conversation

thorstenhater
Copy link
Contributor

@thorstenhater thorstenhater commented Nov 2, 2022

lif

  • Add (again) a reset voltage E_R such that V_m = E_R in the refractory period.
  • Make V_m decay towards resting potential E_L instead of 0.
  • Adjust docs and tests accordingly.
  • Double check this against literature.

- Add (again) a reset voltage E_R that for V_m = E_R in the refractory period.
- Make V_m decay towards resting potential E_L instead of 0.
- Adjust docs and tests accordingly.
- Double check this against literature.
Copy link
Contributor

@brenthuisman brenthuisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing!

@thorstenhater
Copy link
Contributor Author

What would that be? :) There are no comments?

2. Otherwise :math:`U'_\mathrm{m}(t) = \sum\limits_\mathrm{spike} w_\mathrm{spike} \cdot\delta(t - t_\mathrm{spike}) -\frac{1}{\tau_\mathrm{m}}U_\mathrm{m}(t)`
0. :math:`U_\mathrm{m}(0) = V_\mathrm{0}`,
1. If the cell is in its refractory state :math:`U_\mathrm{m}(t) = E_\mathrm{R}`
2. Otherwise :math:`U'_\mathrm{m}(t) = \sum\limits_\mathrm{spike} w_\mathrm{spike} \cdot\delta(t - t_\mathrm{spike}) - \frac{1}{\tau_\mathrm{m}}\left(U_\mathrm{m}(t)) - E_\mathrm{L}\right)`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w_\mathrm{spike} is not defined above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's not part of the cell, but it should still be defined somewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There, it is now explained. I added C++ API docs for LIF as well.

Copy link
Contributor

@brenthuisman brenthuisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray!

@brenthuisman brenthuisman merged commit 2bea825 into arbor-sim:master Nov 3, 2022
@thorstenhater thorstenhater deleted the feat/lif-e_reset branch November 3, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants