Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI workflow and GoogleTest #2003

Merged
merged 23 commits into from
Oct 19, 2022
Merged

Bump CI workflow and GoogleTest #2003

merged 23 commits into from
Oct 19, 2022

Conversation

boeschf
Copy link
Contributor

@boeschf boeschf commented Oct 17, 2022

[TH] Github bumps its CI environment

  • Upgrade actions to latest
    • cache
    • checkout
    • cmake
  • Bump minimal tested versions of clang and GCC to 9
  • Remove Ubuntu 18.04 LTS and use 20.04 LTS a the new minimum.
    • GH drops support for 18.04

[FB] bump googletest version

  • added version 1.12.1 as git submodule as requested in Formal dependency version management #1731
  • previous version was ancient and caused heap corruptions at test cleanup stage
  • updated deprecated gtest macros
  • changed include paths in files that include gtest.h
  • made stream operator in arbor/include/arbor/spike.hpp part of arb namespace - this fixes a compiler/linker bug for older compilers

@boeschf boeschf changed the title use fetch_content for gtest newer gtest Oct 18, 2022
@boeschf boeschf changed the title newer gtest Bump CI workflow and GoogleTest Oct 18, 2022
@boeschf boeschf marked this pull request as ready for review October 18, 2022 16:53
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only dubious part is CMake, but that might just be CMake, honestly.

ext/CMakeLists.txt Show resolved Hide resolved
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@boeschf boeschf merged commit 72624d9 into arbor-sim:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants