Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_asc Python fix #1977

Merged
merged 3 commits into from
Sep 20, 2022
Merged

load_asc Python fix #1977

merged 3 commits into from
Sep 20, 2022

Conversation

lukasgd
Copy link
Contributor

@lukasgd lukasgd commented Sep 13, 2022

The load_asc in Python failed as the C++ function it expects a filename, not a string like contents added in #1937.

thorstenhater
thorstenhater requested changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@thorstenhater thorstenhater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for spotting & fixing this. It's actually quite worrying that this is never exercised in a test.

Please do add a test to ensure this never comes up again; you can simply reuse the code from the SWC loaders.

@lukasgd
Copy link
Contributor Author

lukasgd commented Sep 15, 2022

94b060b should address this,

thorstenhater
thorstenhater requested changes Sep 16, 2022
View reviewed changes
arborio/neurolucida.cpp Show resolved Hide resolved
python/morphology.cpp Outdated Show resolved Hide resolved
@brenthuisman brenthuisman merged commit 1a6f44d into arbor-sim:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thorstenhater thorstenhater thorstenhater approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasgd @thorstenhater @brenthuisman