🐍 Rename spike detector -> threshold detector #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmitts
reviewed
Sep 13, 2022
schmitts
reviewed
Sep 13, 2022
schmitts
suggested changes
Sep 13, 2022
|
Yes, of course. But: less confusion across C++/Python and a clearer name. It's also still pre-1.0 |
|
I appreciate the excitement for homogenising APIs, but any particular reason? |
|
This name has been confusing me for some time now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
spike_detectortothreshold_detectorand makespike_detectorthrow a deprecation error.This brings the Python API more in line with C++ and is closer to the object's actual function.
Closes #1642