Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch symdiff errors. #1964

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

thorstenhater
Copy link
Contributor

@thorstenhater thorstenhater commented Aug 26, 2022

  • Make symbolic differentiation return a more refined type.
  • Catch said error when trying to test for linearity
  • Catch the propagated error in CNExp and recommend using a different one.
  • Straighten out the error printing at top level
  • Add regression tests

Closes #1893

New output show the full error stack

bin/modcc bug_1893/bug_1893.mod -N 'arb::allen_catalogue' -t cpu -t gpu
error trace:
  * bug_1893/bug_1893.mod:(line 27,col 26) symbolic differential of unrecognized binary expression
  * bug_1893/bug_1893.mod:(line 27,col 10) CNExp: Could not determine linearity, maybe use a different solver?

modcc/symdiff.cpp Outdated Show resolved Hide resolved
boeschf
boeschf previously approved these changes Sep 5, 2022
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please consider changing the error message

@thorstenhater
Copy link
Contributor Author

@boeschf I fear you to r'approve.

@thorstenhater thorstenhater merged commit 8494607 into arbor-sim:master Sep 5, 2022
@thorstenhater thorstenhater deleted the modcc/segv-compare branch September 5, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modcc segfaults in conjunction with comparison
2 participants