Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more visibility to decor. #1953

Merged
merged 7 commits into from
Aug 23, 2022
Merged

Add more visibility to decor. #1953

merged 7 commits into from
Aug 23, 2022

Conversation

thorstenhater
Copy link
Contributor

@thorstenhater thorstenhater commented Aug 19, 2022 •
edited
Loading

Functionality to

  • delete ions from global properties
  • peek into global properties
  • expose painted, placed, and defaulted items
  • expose voltage limit to python
  • make voltage limit an optional to allow for arbitrary values.
  • Add ion_settings view to python = (valence, ion_data, rev_pot_method)

Documentation

  • cable cell properties in python

Closes #1578
Closes #1577
Closes #1607

AdhocMan
AdhocMan requested changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@AdhocMan AdhocMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments that need updating as well

arbor/fvm_lowered_cell_impl.hpp Outdated Show resolved Hide resolved
arbor/include/arbor/cable_cell_param.hpp Outdated Show resolved Hide resolved
doc/cpp/cable_cell.rst Outdated Show resolved Hide resolved
AdhocMan
AdhocMan approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@AdhocMan AdhocMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I'll leave the merge commit message to you on this one.

brenthuisman
brenthuisman suggested changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@brenthuisman brenthuisman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing updates to Python API docs, e.g. python/decor.rst.

@brenthuisman brenthuisman merged commit 4505986 into arbor-sim:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brenthuisman brenthuisman brenthuisman approved these changes

@AdhocMan AdhocMan AdhocMan approved these changes

@boeschf boeschf Awaiting requested review from boeschf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@thorstenhater @brenthuisman @AdhocMan