Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two context decomp swaps were forgotten #1912

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Two context decomp swaps were forgotten #1912

merged 3 commits into from
Jun 21, 2022

Conversation

brenthuisman
Copy link
Contributor

@brenthuisman brenthuisman commented Jun 21, 2022 •
edited
Loading

In the simulation object argument swap, two were forgotten.

@brenthuisman brenthuisman changed the title one context decomp swap was forgotten Two context decomp swaps were forgotten Jun 21, 2022
@brenthuisman brenthuisman marked this pull request as ready for review June 21, 2022 14:57
AdhocMan
AdhocMan approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@AdhocMan AdhocMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brenthuisman brenthuisman merged commit 49ae16a into arbor-sim:master Jun 21, 2022
@brenthuisman brenthuisman deleted the hotfix-1 branch June 21, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdhocMan AdhocMan AdhocMan approved these changes

@thorstenhater thorstenhater Awaiting requested review from thorstenhater

Assignees
No one assigned
Labels
broke the build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenthuisman @AdhocMan