CMake CUDA clean-up. #1804
Merged
CMake CUDA clean-up. #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
2 tasks
tryBuild failed: |
|
bors try |
noraabiakar
reviewed
Jan 20, 2022
| # The CUDA package is needed for clang compilation for the same reasons as above. | ||
| # enable_langaue(CUDA) has a bug with clang | ||
| find_package(CUDA 10 REQUIRED) | ||
| enable_language(CUDA) |
There was a problem hiding this comment.
Duplicate of line 114.
There was a problem hiding this comment.
Yes, since we are here checking for CUDA-clang and CUDA in l114
tryBuild failed: |
|
bors try |
tryBuild succeeded: |
noraabiakar
reviewed
Jan 21, 2022
There was a problem hiding this comment.
lgtm!
But we need to update the minimum CMake version in the docs: https://docs.arbor-sim.org/en/latest/install/build_install.html
|
bors try |
noraabiakar
approved these changes
Jan 21, 2022
tryBuild succeeded: |
max9901
pushed a commit
to max9901/arbor
that referenced
this pull request
Feb 3, 2022
- Bump CMake to 3.18 for better CUDA support. - Clean-up our use of said support. - Remove old cruft and workarounds. - Maintenance in CI: enable MacOS 11; bump CMake versions to 3.18 / 3.22; bump bors CMake to 3.18 Fixes arbor-sim#1790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump CMake to 3.18 for better CUDA support
Clean-up our use of said support
Remove old cruft and workarounds
Maintenance in CI
Fixes #1790