Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve non-linear systems that are not kinetic schemes. #1724

Merged

Conversation

noraabiakar
Copy link
Contributor

Some refactoring of the SOLVE statement handling in module.cpp.
Allow the usage of SparseNonlinearSolverVisitor for non-linear systems not only when in the form of a kinetic scheme.
Check linearity of kinetic schemes and linear systems (was previously skipped).

Copy link
Contributor

@halfflat halfflat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is it worth adding a unit test (for modcc or in arbor unit)?

@noraabiakar
Copy link
Contributor Author

I think we should. I'll see where it would best fit :)

@noraabiakar
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Oct 21, 2021
@bors
Copy link

bors bot commented Oct 22, 2021

try

Timed out.

@bcumming bcumming merged commit ea25d7a into arbor-sim:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants