Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categorise ASSIGNED RANGE variables as STATE-ish. #1624

Merged
merged 6 commits into from
Aug 24, 2021
Merged

Categorise ASSIGNED RANGE variables as STATE-ish. #1624

merged 6 commits into from
Aug 24, 2021

Conversation

thorstenhater
Copy link
Contributor

Fixes #1623.

Also use the opportunity to clean up the infoprinter.

@thorstenhater
Categorise ASSIGNED RANGE variables as STATE-ish.
be61f31 
Fixes arbor-sim#1623.

Also use the opportunity to clean up the infoprinter.
@thorstenhater thorstenhater marked this pull request as draft August 12, 2021 11:32
@thorstenhater
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 12, 2021
@bors
Try #1624:
64f8258
@thorstenhater
Copy link
Contributor Author

bors try

@bors
Copy link

bors bot commented Aug 12, 2021

try

Already running a review

@thorstenhater
Copy link
Contributor Author

bors try

@bors
Copy link

bors bot commented Aug 12, 2021

try

Already running a review

@thorstenhater thorstenhater marked this pull request as ready for review August 12, 2021 18:51
@bors
Copy link

bors bot commented Aug 12, 2021

try

Timed out.

@noraabiakar
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Aug 24, 2021
@bors
Try #1624:
dba3433
@bors
Copy link

bors bot commented Aug 24, 2021

try

Build failed:

noraabiakar
noraabiakar approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@noraabiakar noraabiakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
One minor comment but I'm approving.

modcc/printer/printerutil.hpp Outdated Show resolved Hide resolved
@thorstenhater thorstenhater merged commit a373f08 into arbor-sim:master Aug 24, 2021
@thorstenhater thorstenhater deleted the bug/1623 branch August 1, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noraabiakar noraabiakar noraabiakar approved these changes

@halfflat halfflat Awaiting requested review from halfflat

@bcumming bcumming Awaiting requested review from bcumming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NMODL ASSIGNED variables appear as PARAMETER in mech_info
2 participants
@thorstenhater @noraabiakar