Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpi.py updated for new synapse labelling #1602

Merged
merged 5 commits into from
Jul 2, 2021
Merged

mpi.py updated for new synapse labelling #1602

merged 5 commits into from
Jul 2, 2021

Conversation

brenthuisman
Copy link
Contributor

No description provided.

noraabiakar
noraabiakar suggested changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@noraabiakar noraabiakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I missed this file because I didn't know it was an example. Can we rename it to something other than mpi.py? Maybe distributed_network_ring.py? Also, is it possible to add it to the CI?

@brenthuisman
Copy link
Contributor Author

You are right. Since I like to be able to end up with meaningful grouping when sorting directories alphabetically (alphanumerically?), I propose network_ring_mpi.py.

@brenthuisman brenthuisman self-assigned this Jun 30, 2021
@noraabiakar noraabiakar merged commit 9fed4a9 into arbor-sim:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noraabiakar noraabiakar noraabiakar approved these changes

Assignees

@brenthuisman brenthuisman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenthuisman @noraabiakar