fix: non-facet aggregations use correct countQuery to get total numbe… #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r of documents. Fixes issues where `useFacet` cannot be true (e.g. use of `$search` in a pipeline) returning only a single page of results as seen aravindnc#60
|
Seeing after pushing that my linter is apparently a little more aggressive on styling so let me know if you want me to tidy that up @aravindnc |
|
@MattLicense No worries. |
|
That should be it sorted now @aravindnc - sorry about that, forgot that |
|
@MattLicense Seems the test case is failing again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r of documents.
Fixes issues where
useFacetcannot be true (e.g. use of$searchin a pipeline) returning only a single page of results as seen #60