Check member failure #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test for agents & coordinators. [ci LONG=1] [ci TESTOPTIONS="-test.run ^TestMemberResilience"]
kvahed
reviewed
Apr 3, 2018
pkg/util/arangod/agency_health.go
Outdated
| // The function returns nil when all agents are healthy or an error when something is wrong. | ||
| func AreAgentsHealthy(ctx context.Context, clients []Agency) error { | ||
| wg := sync.WaitGroup{} | ||
| invalidKey := []string{"does-not-exists-149e97e8-4b81-5664-a8a8-9ba93881d64c"} |
There was a problem hiding this comment.
Just for purpose of beauty: drop the s in exists?
kvahed
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new high level layer of checks to improve resilience.
It introduced a phase "Failed" for a member. When a member has reached that phase, there is no hope of recovery and it will be removed. The existing reconciliation rules ensure that a new member will be added.
The resilience check goes over all members and checks for signs that the member is dead beyond hope of recovery. If so, it checks if the member is allowed to be replaced. If that is all the case, the member phase is set to failed. The reconciler will create a plan to remove it.