Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scale-up #78

Merged
merged 1 commit into from
Mar 26, 2018
+5 −0
Merged

Fix scale-up #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pkg/deployment/reconcile/plan_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ func (d *Reconciler) ExecutePlan(ctx context.Context) (bool, error) {
Msg("Failed to start action")
return false, maskAny(err)
}
// action.Start may have changed status, so reload it.
status = d.context.GetStatus()
// Update status according to result on action.Start.
if ready {
// Remove action from list
status.Plan = status.Plan[1:]
Expand Down Expand Up @@ -91,6 +94,8 @@ func (d *Reconciler) ExecutePlan(ctx context.Context) (bool, error) {
return false, maskAny(err)
}
if ready {
// action.CheckProgress may have changed status, so reload it.
status = d.context.GetStatus()
// Remove action from list
status.Plan = status.Plan[1:]
// Save plan update
Expand Down