Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also watch changes in PVCs and Services #74

Merged
merged 4 commits into from
Mar 26, 2018
Merged

Also watch changes in PVCs and Services #74

merged 4 commits into from
Mar 26, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Mar 26, 2018 •
edited
Loading

This PR changes:

  • The operator will actively watch changes in Services & PVC's and ensure that they are created in every inspection loop. Manually deleting one will trigger a re-create now.
  • Specific event types for pod added/removed/updated are removed, since we just want to trigger an inspection round and not care about what exactly caused that.

@ewoutp ewoutp added the 9 WIP label Mar 26, 2018
neunhoef
neunhoef approved these changes Mar 26, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 284b2e2 into master Mar 26, 2018
@ewoutp ewoutp deleted the watch-more-resources branch March 26, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees
No one assigned
Labels
9 Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @neunhoef