Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store accepted spec #68

Merged
merged 11 commits into from
Mar 23, 2018
Merged

Store accepted spec #68

merged 11 commits into from
Mar 23, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Mar 23, 2018

This PR adds the accepted spec to the status of the deployment.
This is done, so (even when the operator itself is down) when an ArangoDeployment is updated, we know what to compare it to.

To make the process of finding default values better, all simple typed fields in the spec have been converted to references. This allows for the detection of "field is not set" to be different from "field is empty".

Copy link
Contributor

@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot find errors.

@ewoutp ewoutp merged commit 2af40ca into master Mar 23, 2018
@ewoutp ewoutp deleted the store-accepted-spec branch March 23, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants