add test for different deployments #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObiWahn
force-pushed
the
test/different-deployments
branch
9 times, most recently
from
89ded28 to
6081d4f
Compare
|
Should tests that contain multiple deployments at the same time be added here? |
ewoutp
suggested changes
Mar 23, 2018
tests/deployments_test.go
Outdated
|
|
||
| // Prepare deployment config | ||
| deploymentTemplate := newDeployment("test-1-deployment-" + string(mode) + "-" + string(engine) + "-" + uniuri.NewLen(4)) | ||
| deploymentTemplate.Spec.Mode = mode |
There was a problem hiding this comment.
Please merge in master.
After that, this code will no longer compile since Mode & StorageEngine are now references.
Fix it like this:
deploymentTemplate.Spec.Mode = api.NewMode(mode)
deploymentTemplate.Spec.StorageEngine = api.NewStorageEngine(engine)
tests/deployments_test.go
Outdated
|
|
||
| k8sNameSpace := getNamespace(t) | ||
| k8sClient := mustNewKubeClient(t) | ||
| deploymentClient := kubeArangoClient.MustNewInCluster() // |
There was a problem hiding this comment.
// without comment
either remove or fill in comment
tests/deployments_test.go
Outdated
| DBClient := mustNewArangodDatabaseClient(ctx, k8sClient, deployment, t) | ||
|
|
||
| // deployment checks | ||
| if deployment.Spec.Mode == api.DeploymentModeCluster { |
There was a problem hiding this comment.
After master merge, change deployment.Spec.Mode to deployment.Spec.GetMode()
tests/deployments_test.go
Outdated
| }); err != nil { | ||
| t.Fatalf("Cluster not running in expected health in time: %v", err) | ||
| } | ||
| } else if deployment.Spec.Mode == api.DeploymentModeSingle { |
tests/deployments_test.go
Outdated
| t.Fatalf("Single Server not running in time: %v", err) | ||
| } | ||
| } else { | ||
| t.Fatalf("DeploymentMode %v is not supported!", deployment.Spec.Mode) |
tests/deployments_test.go
Outdated
|
|
||
| // environements: provided from outside | ||
|
|
||
| func TestDeploymentSingleMMFiles(t *testing.T) { |
There was a problem hiding this comment.
All exported functions must have a comment.
For test functions, explain what the test is intended to test.
This could be "// TestDeploymentSingleMMFiles tests the successful creation of a deployment of a single server with mmfiles storage engine"
ObiWahn
force-pushed
the
test/different-deployments
branch
from
76f42c2 to
6ee0b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.