Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding event support #6

Merged
merged 2 commits into from
Feb 23, 2018
Merged

Adding event support #6

merged 2 commits into from
Feb 23, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Feb 16, 2018 •
edited
Loading

This PR adds event support that show up in a kubectl describe of an ArangoDeployment like this:

Events:
  Type    Reason                 Age   From                                Message
  ----    ------                 ----  ----                                -------
  Normal  New Agent Added        1m    arangodb-operator-5f7dcb66bc-nj464  New agent example-simple-cluster-agent-t1wtiqfn added to deployment
  Normal  New Agent Added        1m    arangodb-operator-5f7dcb66bc-nj464  New agent example-simple-cluster-agent-uljce1xl added to deployment
  Normal  New Dbserver Added     59s   arangodb-operator-5f7dcb66bc-nj464  New dbserver example-simple-cluster-dbserver-x4oq15e0 added to deployment
  Normal  New Agent Added        59s   arangodb-operator-5f7dcb66bc-nj464  New agent example-simple-cluster-agent-txehlav7 added to deployment
  Normal  New Dbserver Added     59s   arangodb-operator-5f7dcb66bc-nj464  New dbserver example-simple-cluster-dbserver-zmii6mri added to deployment
  Normal  New Dbserver Added     58s   arangodb-operator-5f7dcb66bc-nj464  New dbserver example-simple-cluster-dbserver-p5c4emsk added to deployment
  Normal  New Coordinator Added  58s   arangodb-operator-5f7dcb66bc-nj464  New coordinator example-simple-cluster-coordinator-rqmxcwt8 added to deployment
  Normal  New Coordinator Added  57s   arangodb-operator-5f7dcb66bc-nj464  New coordinator example-simple-cluster-coordinator-kyyow2de added to deployment
  Normal  New Coordinator Added  57s   arangodb-operator-5f7dcb66bc-nj464  New coordinator example-simple-cluster-coordinator-bla7ocby added to deployment

This PR extends #5

@ewoutp ewoutp requested a review from neunhoef February 16, 2018 11:26
ObiWahn
ObiWahn approved these changes Feb 23, 2018
View reviewed changes
Copy link
Contributor

@ObiWahn ObiWahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 9329b3b into master Feb 23, 2018
@ewoutp ewoutp deleted the events branch February 23, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ObiWahn ObiWahn ObiWahn approved these changes

@neunhoef neunhoef Awaiting requested review from neunhoef

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @ObiWahn