Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ssl support for scaling test #53

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Adds ssl support for scaling test #53

merged 1 commit into from
Mar 20, 2018

Conversation

ObiWahn
Copy link
Contributor

@ObiWahn ObiWahn commented Mar 19, 2018

No description provided.

@ObiWahn ObiWahn requested a review from ewoutp March 19, 2018 12:29
@ObiWahn ObiWahn force-pushed the test/ci-scale-ssl branch 2 times, most recently from 5e984a0 to 024a569 Compare March 19, 2018 13:46
@ObiWahn ObiWahn force-pushed the test/ci-scale-ssl branch from 024a569 to f27d150 Compare March 19, 2018 13:56
ewoutp
ewoutp approved these changes Mar 19, 2018
View reviewed changes
Copy link
Contributor

@ewoutp ewoutp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to rename TestScaleClusterTLS to TestScaleCluster since TLS is the default.

After that, LGTM

@ObiWahn ObiWahn merged commit 3c9d7ff into master Mar 20, 2018
@ObiWahn ObiWahn deleted the test/ci-scale-ssl branch March 20, 2018 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewoutp ewoutp ewoutp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ObiWahn @ewoutp