Cleaning up deployment, avoiding docker overrides #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way a developer build & tests the operator.
The intent in to avoid pushing images to
arangdb/arango-operatorby accident.With this PR you have to set a
DOCKERNAMESPACEenvironent variable before calling make.Set this variable to your docker account name.
If will result in docker images such as
<yourDockerAccount>/arango-operator:devAfter building the docker image, a deployment manifest is build that contains everything needed
to run the operator (RBAC resources & deployment resource).
By default the deployment will be created in the
defaultnamespace.To change this, set a
DEPLOYMENTNAMESPACEenvironment variable before calling make.To test the operator, run: