-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS support #43
TLS support #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, found some commented out code, still needed?
optionPair{"--ssl.keyfile", keyPath}, | ||
optionPair{"--ssl.ecdh-curve", ""}, // This way arangod accepts curves other than P256 as well. | ||
) | ||
/*if bsCfg.SslKeyFile != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is about client certificate authentication support, which is not in the scope of this PR
This PR implements support for TLS on the arangod servers.