Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked TLS spec #41

Merged
merged 2 commits into from
Mar 9, 2018
Merged

Reworked TLS spec #41

merged 2 commits into from
Mar 9, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Mar 9, 2018

No description provided.

neunhoef
neunhoef approved these changes Mar 9, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one little addition in comment.

docs/user/custom_resource.md Outdated

If you specify a name of a `Secret` that does not exist, a certificate + key is created
using the values of `spec.ssl.serverName` & `spec.ssl.organizationName`
If you specify a name of a `Secret` that does not exist, a CA certificate + key is created
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "self-signed"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ewoutp ewoutp merged commit afa315a into master Mar 9, 2018
@ewoutp ewoutp deleted the tls-spec branch March 9, 2018 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @neunhoef