Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating pods #4

Merged
merged 3 commits into from
Feb 16, 2018
Merged

Creating pods #4

merged 3 commits into from
Feb 16, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Feb 15, 2018

This PR ensures Pod's are created when the deployment is being added

@ewoutp ewoutp requested a review from neunhoef February 15, 2018 15:56
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two questions in places where stuff is still commented out. Please ignore if this is intentional.


// Endpoint
listenAddr := "[::]"
/* if apiObject.Spec.Di.DisableIPv6 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentionally commented out?

optionPair{"--database.directory", k8sutil.ArangodVolumeMountDir},
optionPair{"--log.output", "+"},
)
/* if config.ServerThreads != 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both still on todo list (like many more)

@ewoutp ewoutp merged commit 6ec749c into master Feb 16, 2018
@ewoutp ewoutp deleted the creating-pods branch February 16, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants