Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use jwt-keyfile option if available. #318

Merged
merged 4 commits into from
Jan 3, 2019
Merged

Use jwt-keyfile option if available. #318

merged 4 commits into from
Jan 3, 2019

Conversation

maierlars
Copy link
Collaborator

This is untested because no image available.

@maierlars maierlars self-assigned this Jan 1, 2019
@maierlars maierlars requested review from ewoutp and neunhoef January 1, 2019 14:42
@ghost ghost added the 2 - Working label Jan 1, 2019
ewoutp
ewoutp suggested changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@ewoutp ewoutp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

pkg/deployment/resources/pod_creator.go Outdated Show resolved Hide resolved
pkg/deployment/resources/pod_creator.go Show resolved Hide resolved
neunhoef
neunhoef requested changes Jan 2, 2019
View reviewed changes
pkg/deployment/resources/pod_creator.go Outdated Show resolved Hide resolved
pkg/util/k8sutil/pods.go Outdated Show resolved Hide resolved
@ghost ghost assigned neunhoef Jan 2, 2019
neunhoef
neunhoef approved these changes Jan 2, 2019
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neunhoef neunhoef merged commit 77b6cbc into master Jan 3, 2019
@ghost ghost removed the 2 - Working label Jan 3, 2019
@neunhoef neunhoef deleted the feature/jwt-keyfile branch January 3, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewoutp ewoutp ewoutp requested changes

@neunhoef neunhoef neunhoef approved these changes

Assignees

@neunhoef neunhoef

@maierlars maierlars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maierlars @ewoutp @neunhoef