Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing uninitialised lastNumberOfServers. #294

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

maierlars
Copy link
Collaborator

@maierlars maierlars commented Nov 5, 2018

Previously the spec was updated every two seconds with the values written in the agency. This was due to a change that was done so that the operator will respect the ui after being redeployed.

The root cause seems to be a uninitialised lastNumberOfServers struct.

Ignore debug output.

@maierlars maierlars requested a review from neunhoef November 5, 2018 22:18
@ghost ghost assigned maierlars Nov 5, 2018
@ghost ghost added the 2 - Working label Nov 5, 2018
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das sieht alles gut aus. An einer Stelle ist eine Lockung auskommentiert. Ist das Absicht? Wollen wir den ganzen Debugging-Output haben?

pkg/deployment/cluster_scaling_integration.go Outdated Show resolved Hide resolved
pkg/deployment/cluster_scaling_integration.go Outdated Show resolved Hide resolved
@neunhoef neunhoef merged commit e6f81f4 into master Nov 6, 2018
@neunhoef neunhoef deleted the bug-fix/scale-integration-error branch November 6, 2018 09:04
@ghost ghost removed the 2 - Working label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants