Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed readiness route. #276

Merged
merged 4 commits into from
Oct 26, 2018
Merged

Fixed readiness route. #276

merged 4 commits into from
Oct 26, 2018

Conversation

maierlars
Copy link
Collaborator

No description provided.

@maierlars maierlars self-assigned this Oct 25, 2018
@ghost ghost added the 2 - Working label Oct 25, 2018
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neunhoef neunhoef merged commit d862e71 into master Oct 26, 2018
@neunhoef neunhoef deleted the bug-fix/readiness-upgrade-fix branch October 26, 2018 13:20
@ghost ghost removed the 2 - Working label Oct 26, 2018
@@ -369,7 +369,7 @@ func (r *Resources) createReadinessProbe(spec api.DeploymentSpec, group api.Serv
}
}
probeCfg := &k8sutil.HTTPProbeConfig{
LocalPath: "/_api/version",
LocalPath: "/_admin/server/availability",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this more robust and choose route depending on version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants