Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resilience improvements #246

Merged
merged 20 commits into from
Sep 7, 2018
Merged

Resilience improvements #246

merged 20 commits into from
Sep 7, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Aug 27, 2018

This PR fixes:

  • Bugs in the resilience tests
  • Bug that deletes a Pod when a PVC is deleted without any checks. That caused the Pod to be deleted (potentially) before it had a chance to cleanout etc.

@ghost ghost assigned ewoutp Aug 27, 2018
@ghost ghost added the 2 - Working label Aug 27, 2018
ewoutp
ewoutp commented Sep 7, 2018
View reviewed changes
pkg/deployment/resources/pvc_inspector.go Outdated
nextInterval = nextInterval.ReduceTo(x)
}
}
if updateMemberStatusNeeded {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check for obsolete

maierlars
maierlars approved these changes Sep 7, 2018
View reviewed changes
Copy link
Collaborator

@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/deployment/resources/deployment_health.go Outdated
}
}

// cleanupRemovedClusterMembers removes all arangod members that are no longer part of the cluster.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Irrelevant comment

@ewoutp ewoutp merged commit 82f70fb into master Sep 7, 2018
@ewoutp ewoutp deleted the bugfix/resilience-improvements branch September 7, 2018 12:38
@ghost ghost removed the 4 - Review label Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maierlars maierlars maierlars approved these changes

Assignees

@ewoutp ewoutp

Labels
Team Clifton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @maierlars