Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject critical options during validation fixes #207 #243

Merged
merged 2 commits into from
Aug 30, 2018
Merged

Reject critical options during validation fixes #207 #243

merged 2 commits into from
Aug 30, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Aug 21, 2018 •
edited
Loading

This PR prevents overriding critical arangod & arangosync arguments by validating the args list of the server groups.

@ghost ghost assigned ewoutp Aug 21, 2018
@ghost ghost added the 2 - Working label Aug 21, 2018
@ewoutp ewoutp requested review from kvahed and neunhoef August 27, 2018 12:24
maierlars
maierlars approved these changes Aug 30, 2018
View reviewed changes
Copy link
Collaborator

@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 23b0283 into master Aug 30, 2018
@ewoutp ewoutp deleted the bugfix/reject-critical-args branch August 30, 2018 10:00
@ghost ghost removed the 4 - Review label Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maierlars maierlars maierlars approved these changes

@kvahed kvahed Awaiting requested review from kvahed

@neunhoef neunhoef Awaiting requested review from neunhoef

Assignees

@ewoutp ewoutp

Labels
Team Clifton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @maierlars