Use new CurrentImage field to prevent unintended upgrades. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before a new Pod would always use the image given in the spec of an
ArangoDeployment.That could lead to scaling up to new (and unintended) versions.
With this PR a new
current-imagefield is added to the status of anArangoDeployment.When a pod is created, the
current-imageis used. When upgrading, thecurrent-imagefield is updated first, if confirmed that an upgrade is indeed allowed.If an upgrade is not allowed, an event is added to the
ArangoDeployment.