Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitTests for plan_builder #22

Merged
merged 5 commits into from
Mar 1, 2018
Merged

UnitTests for plan_builder #22

merged 5 commits into from
Mar 1, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Mar 1, 2018 •
edited
Loading

This PR makes minor refactorings to the createPlan function to make it a better unit test subject.
It also adds plan builder unit tests.

kvahed
kvahed approved these changes Mar 1, 2018
View reviewed changes
Copy link
Contributor

@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@ewoutp ewoutp merged commit 40dbe27 into master Mar 1, 2018
@ewoutp ewoutp deleted the plan_builder_tests branch March 1, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvahed kvahed kvahed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @kvahed