Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a role=leader label on the Pod who won the leader election #208

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Set a role=leader label on the Pod who won the leader election #208

merged 1 commit into from
Jun 29, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jun 29, 2018 •
edited
Loading

This PR sets a label (role=leader) on the operator Pod who won the leader election.

After this, fetching the logs of the leader deployment operator looks like this

kubectl logs --selector=name=arango-deployment-operator,role=leader

@ghost ghost assigned ewoutp Jun 29, 2018
@ghost ghost added the 2 - Working label Jun 29, 2018
@ewoutp ewoutp requested a review from neunhoef June 29, 2018 11:36
neunhoef
neunhoef approved these changes Jun 29, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit e37cc7b into master Jun 29, 2018
@ghost ghost removed the 4 - Review label Jun 29, 2018
@ewoutp ewoutp deleted the feature/set-leader-role-label branch June 29, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@ewoutp ewoutp

Labels
Team Clifton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @neunhoef