All operator Pods will now reach the Ready state. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
neunhoef
approved these changes
Jun 26, 2018
pkg/operator/operator_leader.go
Outdated
| // runLeaderElection performs a leader election on a lock with given name in | ||
| // the namespace that the operator is deployed in. | ||
| // When the leader election is won, the given callback is called. | ||
| // When the leader election is lost (even after it was won once), the process is killed. |
There was a problem hiding this comment.
This comment confused me. If a new pod tries to get elected and "loses" the election, then the process remains lingering around and will try again. It is only if leadership is lost that the process exits. Please adjust the comment. Code is OK, as far as I see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the Ready state of the Pods that run the operators.
Before such a Pod was only marked Ready when it has won the leader election.
In this PR, such a Pod is marked Ready as soon as a new leader has been detected.
Other changes are:
fixes #198