Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added renewal of deployment TLS CA certificate #181

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Added renewal of deployment TLS CA certificate #181

merged 1 commit into from
Jun 15, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jun 15, 2018 •
edited
Loading

This PR added the replacement of a TLS CA certificate for deployments when:

  • The CA certificate is close to its expiration date (90% of lifetime)
  • The alternate names given in spec.tls.altNames are not found in the certificate. (have been changed by user)

fixes #164

@ewoutp ewoutp self-assigned this Jun 15, 2018
@ewoutp ewoutp requested a review from neunhoef June 15, 2018 09:44
neunhoef
neunhoef approved these changes Jun 15, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 14f4c3b into master Jun 15, 2018
@ewoutp ewoutp deleted the feature/renew-tls-ca-certificate branch June 15, 2018 09:56
@ewoutp ewoutp removed the 4 - Review label Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@ewoutp ewoutp

Labels
Team Clifton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource re-deployments when changing specific specs
2 participants
@ewoutp @neunhoef