Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min dbserver count is 2. Revert phase when cleanout has failed #180

Merged
merged 1 commit into from
Jun 15, 2018
Merged

Min dbserver count is 2. Revert phase when cleanout has failed #180

merged 1 commit into from
Jun 15, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jun 15, 2018 •
edited
Loading

This PR changes the following:

  • Minimum server count for dbserver is always 2
  • Minimum server count for single+activefailover is always 2
  • Members in phase CleanoutServer are reverted to Created when cleanout action fails and causes the reconciliation plan to abort.

fixes #178

@ewoutp ewoutp self-assigned this Jun 15, 2018
@ewoutp ewoutp requested a review from neunhoef June 15, 2018 07:39
neunhoef
neunhoef approved these changes Jun 15, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 180d469 into master Jun 15, 2018
@ewoutp ewoutp deleted the bugfix/min-2-dbservers branch June 15, 2018 07:43
@ewoutp ewoutp removed the 4 - Review label Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@ewoutp ewoutp

Labels
Team Clifton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require at least 2 dbservers for Cluster deployment
2 participants
@ewoutp @neunhoef