Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid useless warnings in log #174

Merged
merged 4 commits into from
Jun 12, 2018
Merged

Avoid useless warnings in log #174

merged 4 commits into from
Jun 12, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jun 12, 2018 •
edited
Loading

This PR holds a collection of changes that all prevent warnings in logs that are not really something to worry about:

  • The scaling cluster integration that cannot reach the cluster while it is still bootstrapping
  • Removing finalizers of resources that are already gone (which is perfectly valid in that case)
  • Reporting that an image ID is not yet know for all 9 pods (where 1 is sufficient)

@ewoutp ewoutp self-assigned this Jun 12, 2018
neunhoef
neunhoef approved these changes Jun 12, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit e5f99cf into master Jun 12, 2018
@ewoutp ewoutp deleted the improvement/allow-early-cluster-inspections-2-fail branch June 12, 2018 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@ewoutp ewoutp

Labels
4 - Review Team Clifton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @neunhoef