Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix ResignJob ID Discovery #1440

Merged
merged 1 commit into from
Oct 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- (Bugfix) Fix VersionCheck args propagation
- (Feature) EnforcedResignLeadership action
- (Maintenance) Make scale_down_candidate annotation obsolete
- (Bugfix) Fix ResignJob ID propagation

## [1.2.33](https://github.com/arangodb/kube-arangodb/tree/1.2.33) (2023-09-27)
- (Maintenance) Bump golang.org/x/net to v0.13.0
Expand Down
35 changes: 35 additions & 0 deletions pkg/deployment/agency/state/job_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
//
// DISCLAIMER
//
// Copyright 2023 ArangoDB GmbH, Cologne, Germany
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// Copyright holder is ArangoDB GmbH, Cologne, Germany
//

package state

import (
"encoding/json"
"testing"

"github.com/stretchr/testify/require"
)

func Test_JobDiscovery(t *testing.T) {
var s DumpState
require.NoError(t, json.Unmarshal(agencyDump310, &s))

require.Len(t, s.Agency.Arango.Target.JobFinished, 2)
}
3 changes: 3 additions & 0 deletions pkg/deployment/agency/state/state_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ var agencyDump38 []byte
//go:embed testdata/agency_dump.3.9.json
var agencyDump39 []byte

//go:embed testdata/agency_dump.3.10.json
var agencyDump310 []byte

//go:embed testdata/agency_dump.3.9.satellite.json
var agencyDump39Satellite []byte

Expand Down
Loading