Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tolerations field to configure tolerations of generated pods. #140

Merged
merged 5 commits into from
May 15, 2018
Merged

Added tolerations field to configure tolerations of generated pods. #140

merged 5 commits into from
May 15, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented May 15, 2018 •
edited
Loading

This PR extends #136 (merged)

Also set default tolerations

@ewoutp ewoutp mentioned this pull request May 15, 2018
Merged
@ewoutp ewoutp changed the title Add settings to tolerations Added tolerations field to configure tolerations of generated pods. May 15, 2018
@ewoutp ewoutp added the 9 WIP label May 15, 2018
@ewoutp ewoutp requested a review from neunhoef May 15, 2018 08:23
neunhoef
neunhoef approved these changes May 15, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 87dd61e into master May 15, 2018
@ewoutp ewoutp deleted the feature/tolerations branch May 15, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees
No one assigned
Labels
9 Review Required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @neunhoef