-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added specification of custom resource #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. In principle LGTM.
environments. | ||
|
||
### `spec.imagePullPolicy: string` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is usually called forcePull or so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in kubernetes. Since this is a know feature for Pods I'll like to stick to that
When an encryption key is used, encryption of the data in the cluster is enabled, | ||
without it encryption is disabled. | ||
The default value is empty. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot be changed after deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
If you specify a name of a `Secret` that does not exist, a random token is created | ||
and stored in a `Secret` with given name. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably cannot be changed aftet deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be changed, but requires a full restart. Documented that
|
||
If you specify a name of a `Secret` that does not exist, a certificate + key is created | ||
using the values of `spec.ssl.serverName` & `spec.ssl.organizationName` | ||
and stored in a `Secret` with given name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can not be changed after deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not?
added servers will not be listed in the certificate. | ||
The default value is empty. | ||
|
||
**TODO Really think this through. Restriction does not sound right.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This sounds awkward.
When not specified, the `spec.image` value is used. | ||
|
||
### `spec.sync.imagePullPolicy: string` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above. Maybr call forcePull?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like to keep as is, see above
|
||
### `spec.sync.mq.type: string` | ||
|
||
This setting sets the type of message queue used by ArangoSync. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not convinced that we ever want to allow Kafka here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we just leave it out for now?
You can override it using args
.
There are more change in here after approval. |
No description provided.