Skip to content

Commit

Permalink
Merge pull request #144 from arangodb/bugfix/openshift
Browse files Browse the repository at this point in the history
Fixes needed to run on latest openshift.
  • Loading branch information
ewoutp authored Jun 1, 2018
2 parents 63835bb + fdc250c commit bf880c1
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
2 changes: 1 addition & 1 deletion manifests/templates/deployment/rbac.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ rules:

---

## Bind the cluster role granting access to ArangoLocalStorage resources
## Bind the cluster role granting access to ArangoDeployment resources
## to the default service account of the configured namespace.
apiVersion: rbac.authorization.k8s.io/v1beta1
kind: RoleBinding
Expand Down
13 changes: 7 additions & 6 deletions pkg/apis/deployment/v1alpha/deployment.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,13 @@ type ArangoDeployment struct {
func (d *ArangoDeployment) AsOwner() metav1.OwnerReference {
trueVar := true
return metav1.OwnerReference{
APIVersion: SchemeGroupVersion.String(),
Kind: ArangoDeploymentResourceKind,
Name: d.Name,
UID: d.UID,
Controller: &trueVar,
BlockOwnerDeletion: &trueVar,
APIVersion: SchemeGroupVersion.String(),
Kind: ArangoDeploymentResourceKind,
Name: d.Name,
UID: d.UID,
Controller: &trueVar,
// For now BlockOwnerDeletion does not work on OpenShift, so we leave it out.
//BlockOwnerDeletion: &trueVar,
}
}

Expand Down
2 changes: 2 additions & 0 deletions pkg/deployment/images.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,8 @@ func (ib *imagesBuilder) fetchArangoDBImageIDAndVersion(ctx context.Context, ima
args := []string{
"--server.authentication=false",
fmt.Sprintf("--server.endpoint=tcp://[::]:%d", k8sutil.ArangoPort),
"--database.directory=" + k8sutil.ArangodVolumeMountDir,
"--log.output=+",
}
terminationGracePeriod := time.Second * 30
tolerations := make([]v1.Toleration, 0, 2)
Expand Down

0 comments on commit bf880c1

Please sign in to comment.