(Bugfix) Proper handling of --agency.retries argument (#1479)

arangodb · Nov 9, 2023 · 686e51b · 686e51b
1 parent 9d0f6e0
commit 686e51b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - (Feature) License Manager
 - (Improvement) Use Async mode for backup creation
 - (Feature) (ML) CRD
+- (Bugfix) Proper handling of --agency.retries argument
 
 ## [1.2.35](https://github.com/arangodb/kube-arangodb/tree/1.2.35) (2023-11-06)
 - (Maintenance) Update go-driver to v1.6.0, update IsNotFound() checks

diff --git a/pkg/deployment/agency/loader_retry.go b/pkg/deployment/agency/loader_retry.go
@@ -79,7 +79,7 @@ func (i *retryLoader[T]) Refresh(ctx context.Context, discovery agencyCache.Lead
 	i.lock.Lock()
 	defer i.lock.Unlock()
 
-	for z := 0; z < i.retries-1; z++ {
+	for z := 0; z < i.retries; z++ {
 		if err := i.parent.Refresh(ctx, discovery); err != nil {
 			logger.Err(err).Debug("Unable to refresh agency while retrying")
 			continue