Remove PodSchedulingFailure condition instead of setting to false

arangodb · Aug 4, 2023 · 050d84a · 050d84a
1 parent 0453352
commit 050d84a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@
 - (Maintenance) Bump K8S Version to 1.25.12
 - (Maintenance) Bump Go to 1.20.7
 - (Improvement) Restart pod if it could not be scheduled and related scheduling parameters changed
+- (Improvement) Remove PodSchedulingFailure condition instead of setting to false
 
 ## [1.2.31](https://github.com/arangodb/kube-arangodb/tree/1.2.31) (2023-07-14)
 - (Improvement) Block traffic on the services if there is more than 1 active leader in ActiveFailover mode

diff --git a/pkg/deployment/resources/pod_inspector.go b/pkg/deployment/resources/pod_inspector.go
@@ -527,9 +527,7 @@ func (r *Resources) InspectPods(ctx context.Context, cachedStatus inspectorInter
 		}
 	} else if status.Conditions.IsTrue(api.ConditionTypePodSchedulingFailure) &&
 		len(unscheduledPodNames) == 0 {
-		if status.Conditions.Update(api.ConditionTypePodSchedulingFailure, false,
-			"Pods Scheduling Resolved",
-			"No pod reports a scheduling timeout") {
+		if status.Conditions.Remove(api.ConditionTypePodSchedulingFailure) {
 			r.context.CreateEvent(k8sutil.NewPodsSchedulingResolvedEvent(r.context.GetAPIObject()))
 		}
 	}