Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc - Fix collection.exists indentation #672

Closed
wants to merge 1 commit into from
Closed

Doc - Fix collection.exists indentation #672

wants to merge 1 commit into from

Conversation

codebling
Copy link

The Collection API page has 2 different heading levels for methods, leading to a confusing indentation in the table of contents:
image

This puts the all of the collection functions at the same level

@pluma
Copy link
Contributor

pluma commented Jul 6, 2020

Thank you for the PR. For legal reasons we need a signed Contributor License Agreement (CLA) before we can merge your code into the project.

You can download the form from our website: https://www.arangodb.com/documents/cla.pdf

Once you've filled out and signed it, please send it to us via e-mail: [email protected] or fax: +49-221-2722999-88.

@codebling
Copy link
Author

codebling commented Jul 6, 2020

This PR/contribution is made in the spirit of FOSS. I understand that this software is a product of ArangoDB GmbH and allow ArangoDB GmbH free use of this code change in any private/public/open source/closed source, whether free or paid.

That being said, I probably won't be signing the document. While I understand the reason for its existence, I have several problems with it:

  • requires signer to read legalese
  • requires signer to reveal personal details
  • can not easily be filled out electronically
  • no clear privacy policy

If you'd like me to sign the document in an image editor with a mouse and fill in "codebling" and my email address, without revealing personal information, I am happy to do that and send it off. Just let me know. As it stands I did not do that as I felt it would only add to the confusion and back and forths and cause more work for everyone. If that's not ok, feel free to commit the same 1 character change on your own.

Consider also implementing an easier CLA process. Check out an easy one here.

@codebling codebling closed this Jul 6, 2020
@pluma
Copy link
Contributor

pluma commented Jul 6, 2020

@codebling I understand your frustration. To my knowledge we require a physical signature to comply with German contract & IP law but I will pass on your suggestion to the CLA team.

If it's any consolation, the v6 documentation currently hosted at https://www.arangodb.com/docs/stable/drivers/js.html is scheduled to be removed in favor of the new API documentation at http://arangodb.github.io/arangojs when v7 is officially released.

@codebling
Copy link
Author

Thanks! v7 documentation looks different but interesting! Thanks for the comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants