Enhance test coverage #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
January 31, 2018 14:49
… into test-enhancement
mvollmary
added
the
Feature Request
pluma
suggested changes
Mar 20, 2018
| .unload() | ||
| .then(info => { | ||
| expect(info).to.have.property("name", collection.name); | ||
| expect(info).to.have.property("status", 2); // unloaded |
There was a problem hiding this comment.
@mpv1989 This seems to be timing dependent. On Linux I'm seeing 4 (being unloaded), you're seeing 2 on Windows. This currently means the test will fail on one of the two platforms depending on the value we hardcode. Any idea how to solve this? Maybe allow for 2 or 4 and assume ArangoDB will eventually unload (i.e. eventually move from 4 to 2).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.