Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAS-5111 | add resources for oasis multi region backup #73

Merged
merged 23 commits into from
Sep 27, 2022
Merged

OAS-5111 | add resources for oasis multi region backup #73

merged 23 commits into from
Sep 27, 2022

Conversation

lakhansamani
Copy link
Contributor

@lakhansamani lakhansamani commented Aug 26, 2022 •
edited
Loading

  • Add resources for oasis multi-region backups
  • Change arangodb version 3.8.6 -> 3.8.7

@lakhansamani lakhansamani changed the title OAS-5111 | add multi region backup OAS-5111 | add resources for oasis multi region backup Aug 26, 2022
@lakhansamani lakhansamani requested a review from adoi August 26, 2022 17:57
Robert-Stam
Robert-Stam reviewed Sep 2, 2022
View reviewed changes
Copy link
Contributor

@Robert-Stam Robert-Stam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the regionIDs in the backup schedule, which m.i. is the most important change, did I miss something?

Makefile Outdated Show resolved Hide resolved
Robert-Stam
Robert-Stam reviewed Sep 6, 2022
View reviewed changes
Copy link
Contributor

@Robert-Stam Robert-Stam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test it runtime to see it works, even if you change the fields after it has created?

internal/resource_backup_policy.go Outdated Show resolved Hide resolved
adoi
adoi suggested changes Sep 14, 2022
View reviewed changes
examples/resources/oasis_multi_region_backup/resource.tf Outdated Show resolved Hide resolved
examples/resources/oasis_multi_region_backup/resource.tf Outdated Show resolved Hide resolved
internal/resource_multi_region_backup_test.go Outdated Show resolved Hide resolved
internal/resource_multi_region_backup_test.go Show resolved Hide resolved
internal/resource_multi_region_backup_test.go Outdated Show resolved Hide resolved
internal/resource_multi_region_backup.go Outdated Show resolved Hide resolved
internal/resource_multi_region_backup.go Outdated Show resolved Hide resolved
internal/resource_backup.go Show resolved Hide resolved
@lakhansamani lakhansamani requested a review from adoi September 15, 2022 13:20
adoi
adoi approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@adoi adoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small remark to be addressed, further LGTM.

examples/resources/oasis_multi_region_backup/README.md Outdated Show resolved Hide resolved
@adoi adoi merged commit 68303a9 into master Sep 27, 2022
@adoi adoi deleted the OAS-5111 branch September 27, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoi adoi adoi approved these changes

@Robert-Stam Robert-Stam Awaiting requested review from Robert-Stam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lakhansamani @adoi @Robert-Stam