Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAS-2041 | BREAKING | Changed IPWhitelist into IPAllowlist #24

Merged
merged 1 commit into from
Jan 11, 2021
Merged

OAS-2041 | BREAKING | Changed IPWhitelist into IPAllowlist #24

merged 1 commit into from
Jan 11, 2021

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jan 11, 2021

No description provided.

@ewoutp ewoutp self-assigned this Jan 11, 2021
@ewoutp ewoutp requested a review from Robert-Stam January 11, 2021 07:40
Robert-Stam
Robert-Stam approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@Robert-Stam Robert-Stam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the fact that the title is the other way around, LGTM.

@ewoutp ewoutp changed the title OAS-2041 | BREAKING | Changed IPAllowlist into IPWhitelist OAS-2041 | BREAKING | Changed IPWhitelist into IPAllowlist Jan 11, 2021
@ewoutp ewoutp merged commit c445b90 into master Jan 11, 2021
@ewoutp ewoutp deleted the removewhitelist branch January 11, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robert-Stam Robert-Stam Robert-Stam approved these changes

Assignees

@ewoutp ewoutp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @Robert-Stam