Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: typos and formatting issues on documentation #434

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Fix: typos and formatting issues on documentation #434

merged 2 commits into from
Aug 7, 2023

Conversation

cgero-eth
Copy link
Contributor

Description

As I was reading the OSx documentation, I found some small typos and formatting issues that have been fixed on this PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@cgero-eth cgero-eth requested a review from brickpop July 24, 2023 07:30
@cgero-eth cgero-eth force-pushed the fix-documentation-formatting-typo branch from f26c88e to 589336e Compare July 31, 2023 16:05
Rekard0
Rekard0 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@Rekard0 Rekard0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cgero-eth cgero-eth merged commit 1688a67 into develop Aug 7, 2023
@heueristik heueristik deleted the fix-documentation-formatting-typo branch September 28, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

@juliettech13 juliettech13 Awaiting requested review from juliettech13

@josemarinas josemarinas Awaiting requested review from josemarinas

@brickpop brickpop Awaiting requested review from brickpop

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cgero-eth @brickpop @Rekard0 @heueristik